Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix determining lower priority #55908

Conversation

LiviaMedeiros
Copy link
Contributor

Follow-up to #55739, making it actually work.
priority means niceness here, so the comparison should be other way around. 😅

Fixes: NixOS/nixpkgs#355919 (should be applied on top of #55739 until both get into release)
Alternative to: #55863 (/cc @aduh95)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (a2edde4) to head (bf80e2b).
Report is 72 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55908   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files         653      653           
  Lines      187735   187735           
  Branches    36181    36177    -4     
=======================================
+ Hits       166141   166145    +4     
+ Misses      14819    14817    -2     
+ Partials     6775     6773    -2     

see 36 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on NixOS, LGTM

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit f270462 into nodejs:main Nov 20, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f270462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lts-watch-v20.x PRs that may need to be released in v20.x needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: nodePackages_latest.nodejs
5 participants